Fix error-codes not updating correctly#10348
Merged
gaearon merged 2 commits intofacebook:masterfrom Aug 2, 2017
Merged
Conversation
Contributor
Author
Collaborator
|
Thanks, this is great! Can you please just leave the fix in without the codes change? We’ll update codes before the release. |
Contributor
Author
|
Sure, reverted codes :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #10328
If I understand correctly, calls to
require()in scripts context get cached into some kind of module map, similarly like injest-haste-map(or maybe are hoisted to the top of module behind the scenes?). At least that's what I observe.Because the cache isn't invalidated after performing
fs.writeFileSync,existingErrorMapwas always the same (despite inlinerequire), resulting incodes.jsonfile not being updated properly.One way to fix this is through replacing
requirewithfs.readFileSyncand that's what this PR is about.